This repository has been archived by the owner on Aug 5, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the following rules:
scalajs_library
scalajs_binary
scalajs_proto_library
Example usage: https://github.com/gvacaliuc/bazel-scalapb-grpcweb-example
This currently works with unary rpc calls, but there is some mangled error that I believe to be from the from the minified grpc-web source on the client side. Confirmed that the server is streaming results back to the client, but the client does not process the returned stream.
I think that there is something called a "source map" which will let us debug from the minified JS to original source (which will help us debug the grpc-web error) and the minifed JS to the original SCALA (so you can debug your scala.js code). The scala.js linker has some options to configure it.
issues
scala_js.bzl
filerules_nodejs
for some of their provider values (so thatscalajs_
rules accurately reflect what they provide rather than masquerading asJavaInfo
providersThis is a good link to understand what's going on with scala.js: http://www.lihaoyi.com/hands-on-scala-js/#TheCompilationPipeline
Motivation